Use genkernel root prefix by default on Gentoo #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have tested this manually on my Gentoo system by booting BEs with both |
zdykstra
requested changes
Jan 19, 2021
Member
zdykstra
left a comment
zdykstra
left a comment
There was a problem hiding this comment.
Please fix indenting to be consistent with the rest of zfsbootmenu-lib.sh and then this is good to go. Thank you!
genkernel is often used to generate the initramfs on Gentoo. An initramfs generated by genkernel accepts a ZFS root option in the form of "root=ZFS=<dataset>", but does not accept "root=zfs:<dataset>", which is the default format for passing the root dataset to the BE initramfs in zfsbootmenu. For Gentoo BEs, make the default root prefix "root=ZFS=", which is accepted by both genkernel- and dracut-generated initramfs. Users can still set the "org.zfsbootmenu:rootprefix" property on "<pool>/ROOT" or the BE datasets to override the default. Fixes: zbm-dev#136.
vozhyk-
force-pushed
the
136-use-genkernel-root-prefix-on-gentoo
branch
from
b29cfac to
d0cc1ff
Compare
Member
|
Your help getting this up-to-snuff for Gentoo is greatly appreciated! |
Contributor
Author
|
Thank you too for the prompt replies and suggestions on solving problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genkernelis often used to generate the initramfs on Gentoo.An initramfs generated by genkernel accepts a ZFS root option
in the form of
root=ZFS=<dataset>,but does not accept
root=zfs:<dataset>,which is the default format for passing the root dataset
to the BE initramfs in
zfsbootmenu.For Gentoo BEs, make the default root prefix
root=ZFS=,which is accepted by both
genkernel- anddracut-generated initramfs.Users can still set the
org.zfsbootmenu:rootprefixpropertyon
<pool>/ROOTor the BE datasets to override the default.Fixes: #136.