Allow BE and snapshot sorting by different criteria #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems with a large number of boot environments or snapshots, sorting by name can be less than optimal. This PR adds the following:
zbm.sort_keyto be set on the KCL, withname,creation,usedconsidered valid sort keysmod-oon the BE and snapshot list screens, allowing the sorting method to be changed. Changing the sorting method on one screen changes it on the other, as well. This change persists untilzfsbootmenu.shis exited, at which point the selected method reverts to the default (name) or the method defined on the KCL.Packing the sort methods into the global
zbm_sortvariable allows easy expansion of sort keys in the future. Simply add the list of valid keys to the array in parse-commandline.sh and it will be accepted and rotated through the list.The shortcut key combinations have been documented in the online help and the man page, but not in the footer text. I'm open to persuasion on this.
Closes #137