-
Notifications
You must be signed in to change notification settings - Fork 95
Logging lifecycle #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Logging lifecycle #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71f11c2 to
ae45b37
Compare
ae45b37 to
075aa9c
Compare
ahesford
reviewed
Feb 18, 2021
ahesford
approved these changes
Feb 18, 2021
Member
ahesford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general. We can run it through some more rigorous testing as part of the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to make logging play a more focused role in the ZBM ecosystem. Various components would correctly catch and log an error through
zerror(), but unless you know how to look for them, they were entirely hidden from view. As such, I attempted to meet the following goals:MOD-LIn addition to the error log integrations, I made a pass through virtually every function in
zfsbootmenu-lib.sh. Where positional parameters are non-optional in a function call, a test for empty is performed for each parameter. If the parameter is empty, an error is logged and and the function returns. Some functions had a check / silent return, others did not. They've all been normalized.I've tested the behavior with an x86_64 BE in a ppc64le VM to confirm kexec and chroot error handling.
Are there any other error conditions that should warrant a
timed_prompt, or should the current usage be pared back?One side effect of this work is that the heavy usage of
zdebug()does have a performance impact, so booting ZBM withloglevel=7should now only be done if you actually need debug level logging. Nothing is free.