Store options from KCL in a file for easy sourcing #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfsbootmenu-parse-commandline.sh defines several configuration variables based on KCL arguments; zfsbootmenu-exec.sh originally exported those to the environment for use by zfsbootmenu-countdown.sh and zfsbootmenu.sh. This works fine if zfsbootmenu.sh is only ever run in a local session. When connecting via SSH and launching zfsbootmenu from the shell, these configuration variables are not accessible. The simple solution is to write the configuration into a file that can be sourced by both zfsbootmenu-countdown.sh and zfsbootmenu.sh to populate their environments regardless of the way they are called. The boot-environment list has been renamed from "env" to "bootenvs" to avoid confusion with the "environment" file.
zdykstra
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zfsbootmenu-parse-commandline.shdefines several configuration variables based on KCL arguments;zfsbootmenu-exec.shoriginally exported those to the environment for use byzfsbootmenu-countdown.shandzfsbootmenu.sh. This works fine ifzfsbootmenu.shis only ever run in a local session.When connecting via SSH and launching
zfsbootmenufrom the shell, these configuration variables are not accessible. The simple solution is to write the configuration into a file that can be sourced by bothzfsbootmenu-countdown.shandzfsbootmenu.shto populate their environments regardless of the way they are called.The boot-environment list has been renamed from
envtobootenvsto avoid confusion with theenvironmentfile.