Skip to content

Ensure fzf is installed when building bundle #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashb wants to merge 1 commit into from
Closed

Ensure fzf is installed when building bundle #71

ashb wants to merge 1 commit into from

Conversation

@ashb
Copy link

@ashb ashb commented Aug 20, 2020 •
edited
Loading

If fzf is not installed when building the initrd's then nothing works :)

@zdykstra
Copy link
Member

zdykstra commented Aug 22, 2020

Thank you for this PR! @ahesford and I discussed this out-of-band and we realized that the module needs quite a few more sanity checks during creation. #72 was developed to ensure that a bad/incomplete initramfs can't be built.

@zdykstra zdykstra closed this Aug 22, 2020
@ashb ashb deleted the ensure-fzf-installed branch August 22, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashb @zdykstra