Only send Stop event at end of Gemini completion request
#29885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
force-pushed
the
only-send-stop-event-at-end-of-google-completion-request
branch
from
bdecac0 to
289f2ca
Compare
mgsloan
changed the title
Stop event at end of google completion requestStop event at end of gemini completion request
mgsloan
changed the title
Stop event at end of gemini completion requestStop event at end of Gemini completion request
I don't think this makes much of a difference in current use, but this more closely matches other providers and cleans up the "Response" section of eval markdown output
mgsloan
force-pushed
the
only-send-stop-event-at-end-of-google-completion-request
branch
from
289f2ca to
6187da4
Compare
mgsloan
deleted the
only-send-stop-event-at-end-of-google-completion-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this makes much of a difference in current use, but this more closely matches other providers and cleans up the "Response" section of eval markdown output
Release Notes: