agent_ui: Fix crash when filtering tools in the agent profile tool picker#58299
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
MrSubidubi
approved these changes
Jun 2, 2026
bennetbo
approved these changes
Jun 2, 2026
Member
Author
|
/cherry-pick preview |
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 3, 2026
…cker (#58299) (cherry-pick to preview) (#58395) Cherry-pick of #58299 to preview ---- Closes ZED-8SQ This PR uses the same pattern for `can_select` as other delegates and also guards `can_select` call in `Picker::render_element` which was regressed in #50705. Release Notes: - Fixed a crash that could occur when searching or configuring tools in agent profile settings. Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This was referenced Jun 3, 2026
This was referenced Jun 18, 2026
Closed
liusuren123
pushed a commit
to liusuren123/zed
that referenced
this pull request
Jun 24, 2026
…cker (zed-industries#58299) Closes ZED-8SQ This PR uses the same pattern for `can_select` as other delegates and also guards `can_select` call in `Picker::render_element` which was regressed in zed-industries#50705. Release Notes: - Fixed a crash that could occur when searching or configuring tools in agent profile settings.
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…cker (zed-industries#58299) Closes ZED-8SQ This PR uses the same pattern for `can_select` as other delegates and also guards `can_select` call in `Picker::render_element` which was regressed in zed-industries#50705. Release Notes: - Fixed a crash that could occur when searching or configuring tools in agent profile settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FR-40
This PR uses the same pattern for
can_selectas other delegates and also guardscan_selectcall inPicker::render_elementwhich was regressed in #50705.Release Notes: