Skip to content

fix(break-pane): strip logical position when inserting pane to new tab #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imsnif merged 1 commit into from
Feb 3, 2025
Merged

fix(break-pane): strip logical position when inserting pane to new tab #3973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions zellij-server/src/panes/tiled_panes/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,13 @@ impl TiledPanes {
})
.copied()
{
if let Some(pane) = self.panes.remove(&pane_id) {
self.add_pane(pane.pid(), pane, true, None);
if let Some(mut pane) = self.panes.remove(&pane_id) {
// we must strip the logical position here because it's likely a straggler from
// this pane's previous tab and would cause chaos if considered in the new one
let mut pane_geom = pane.position_and_size();
pane_geom.logical_position = None;
pane.set_geom(pane_geom);
self.add_pane_with_existing_geom(pane.pid(), pane);
}
}
}
Expand Down
Loading