Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Memcached HHVM compatibility and reduced duplicated code #57

Merged
merged 1 commit into from
Apr 16, 2016
Merged

Memcached HHVM compatibility and reduced duplicated code #57

merged 1 commit into from
Apr 16, 2016

Conversation

marc-mabe
Copy link
Member

No description provided.

@marc-mabe marc-mabe changed the title HHVM compatibility and reduced duplicated code Memcached HHVM compatibility and reduced duplicated code Jan 9, 2016
$missingKeys = [];
foreach ($rsCodes as $key => $rsCode) {
$rsCodes = $memc->deleteMulti($normalizedKeys);
foreach ($rsCodes as $normalizedKey => $rsCode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can avoid assigning to $rsCodes here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@marc-mabe
Copy link
Member Author

@Maks3w @Ocramius Is this PR ready for merge now?

@marc-mabe
Copy link
Member Author

@Maks3w @Ocramius ping

@marc-mabe marc-mabe merged commit 3cfab67 into zendframework:master Apr 16, 2016
@marc-mabe marc-mabe added this to the 2.7.1 milestone Apr 16, 2016
@marc-mabe marc-mabe deleted the hhvm_memcached branch February 11, 2017 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants