This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Deprecations to create in 2.6.0 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can tag this methods but can you confirm me this way? /**
* @deprecated This method will be removed since version 3.0
*//**
* @deprecated This class will be removed since version 3.0
*/Thanks |
|
@gianarb Let's go with: /**
* @deprecated This {class or method} is deprecated with 2.6.0, and will be removed in 3.0.0. Please see {link to doc/book/migration/removed.md} for details.
*/I need to figure out where the link will live; likely the develop branch, however. |
|
The link will be https://github.com/zendframework/zend-eventmanager/blob/develop/doc/book/migration/removed.md @gianarb Ping me on IRC if you see this; I plan to start work on it unless I hear from you shortly. :) |
- [X] Mark GlobalEventManager as deprecated - [X] Mark StaticEventManager as deprecated - [X] Mark EventManager::setSharedManager as deprecated - [X] Add SharedEventsCapableInterface - [X] Updated SharedEventManagerAwareInterface to extend SharedEventsCapableInterface - [X] Mark EventManager::unsetSharedManager as deprecated - [X] Mark EventManager(Interface)?::getEvents as deprecated - [X] Mark EventManager(Interface)?::getListeners as deprecated - [X] Mark EventManager(Interface)?::setEventClass as deprecated - [X] Mark EventManager(Interface)?::attachAggregate as deprecated - [X] Mark EventManager(Interface)?::detachAggregate as deprecated - [X] Mark SharedListenerAggregateInterface as deprecated - [X] Mark SharedEventAggregateAwareInterface as deprecated - [X] Mark SharedEventManagerAwareInterface as deprecated - [X] Mark SharedEventManager(Interface)?::getEvents as deprecated - [X] Add EventManager::triggerEvent() (but not at interface level) - [X] Add EventManager::triggerEventUntil() (but not at interface level)
- Per @akrabat, the "3.0.0" verbiage needed to be on the same line as the annotation.
|
Discussed triggering |
|
Looks good to me. |
weierophinney
added a commit
that referenced
this pull request
Sep 29, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 29, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #4, we need to mark a number of features as deprecated for an upcoming 2.6.0 release. This should be done against master.
Deprecations can be done via annotations; all deprecations MUST also be noted in the CHANGELOG.md.