This repository was archived by the owner on Jan 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Added minlength to the validTagAttributes array on multiple elements #211
Merged
weierophinney
merged 3 commits into
zendframework:develop
from
rolandoisidoro:minlength-attribute
Dec 11, 2018
Merged
Added minlength to the validTagAttributes array on multiple elements #211
weierophinney
merged 3 commits into
zendframework:develop
from
rolandoisidoro:minlength-attribute
Dec 11, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h, password, tel and url form elements.
@rolandoisidoro zend-form/test/View/Helper/FormTextTest.php Lines 48 to 81 in 4419eef
|
…tes tests for text, email, password, tel and url element view helpers.
@froschdesign , just extended the tests you mentioned before and added missing tests for |
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
Added minlength to the validTagAttributes array on multiple elements
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
Thanks, @rolandoisidoro! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to issue #206. It will allow developers to set
minlength
attribute ontext
,email
,search
,password
,tel
andurl
form elements, which will enable HTML5 minimum length validation.