This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 30, 2020. It is now read-only.
setUri() invalidates relative URI when setting default ports #36
Description
Hi,
when setting a relative URI /example the Zend\Http\Client::setUri() method adds a default port and so invalidates the URI resulting in isValidRelative() returning FALSE instead of TRUE.
<?php
require './vendor/autoload.php';
$relativeUri = '/example';
$client = new Zend\Http\Client($relativeUri);
$uri = new Zend\Uri\Http($relativeUri);
var_dump($client->getUri()->isValidRelative(), $uri->isValidRelative());Expected output
boolean(true)
boolean(true)
Actual output
boolean(false)
boolean(true)
I don't know how to build a patch, but line 323 of Client.php should be
if (! $this->getUri()->getPort() && $this->getUri()->isAbsolute()) {
instead of
if (! $this->getUri()->getPort()) {
Cheers
Activity
Fixes zendframework#36 Client::setUri() should keep relative uri status
samsonasik commentedon May 6, 2018
@antiphp I've created PR #149 for it
Fixes zendframework#36 Client::setUri() should keep relative uri status
Merge pull request #149 from samsonasik/fix-36
Merge branch 'hotfix/149'