Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Detecting base url for console requests - #165

Merged
weierophinney merged 1 commit into
zendframework:masterfrom
michalbundyra:hotfix/base-url-console-request
Jan 8, 2019
Merged

weierophinney merged 1 commit into
zendframework:masterfrom
michalbundyra:hotfix/base-url-console-request

Conversation

@michalbundyra

Copy link
Copy Markdown
Member

Alternative solution for: zendframework/zend-test#66

Related issue: zendframework/zend-test#71

In zend-test on dispatch from test global variables are set and the base url is detected wrongly in zend-http. Please see test case for more details.

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@weierophinney weierophinney added this to the 2.8.3 milestone Jan 7, 2019
@weierophinney
weierophinney merged commit bedb5c8 into zendframework:master Jan 8, 2019
weierophinney added a commit that referenced this pull request Jan 8, 2019
weierophinney added a commit that referenced this pull request Jan 8, 2019
weierophinney added a commit that referenced this pull request Jan 8, 2019
weierophinney added a commit that referenced this pull request Jan 8, 2019
@weierophinney

Copy link
Copy Markdown
Member

Thanks, @webimpress!

@michalbundyra
michalbundyra deleted the hotfix/base-url-console-request branch January 8, 2019 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants