v3 performance while registering services factories and aliases

[pine3ree]

Working with zend-expressive i found out that migrating to a newer version that included servicemanage 3 the very same test app was much slower. This occurred when registering all zend-form helper plugins.

zendframework/zend-expressive-zendviewrenderer#25
zendframework/zend-form#76

So i decided to prepare and run 2 simple test scripts whose only purpose is to register all zend-form view helpers using zend-servicemanager v2 and v3 and explain the issue here as I believe this repo is more appropriate for this.

v3 test: zend-form configuration time ~ 22 ms (PHP 7.0), ~52-70 ms (PHP 5.6)

cd /my/test/path/sm3
composer require zend-servicemanager:3.0.*
composer require zend-i18n
composer require zend-form
composer require zend-view

<?php
// file /my/test/path/sm3/test.php
require 'vendor/autoload.php';

use Zend\ServiceManager\ServiceManager;
use Zend\ServiceManager\Config;
use Zend\I18n\View\HelperConfig as I18nViewHelperConfig;
use Zend\Form\View\HelperConfig as FormViewHelperConfig;
use Zend\View\HelperPluginManager;

$serviceManager = new ServiceManager();
$helperManager  = new HelperPluginManager($serviceManager);

(new I18nViewHelperConfig())->configureServiceManager($helperManager);

$t0 = microtime(true);
(new FormViewHelperConfig())->configureServiceManager($helperManager);
$ms = 1000 * round(microtime(true) - $t0, 5) . ' ms';

echo 'zend-servicemanager-v3 => ' . $ms . PHP_EOL;

$ php70 test.php # ~ 22 ms
$ php56 test.php # ~52-70 ms

v2 test: zend-form configuration time < 2ms (PHP 7.0), ~7-9 ms (PHP 5.6)

cd /my/test/path/sm2
composer require zend-servicemanager:2.7.*
composer require zend-i18n
composer require zend-form
composer require zend-view

<?php
// file /my/test/path/sm2/test.php
require 'vendor/autoload.php';

use Zend\ServiceManager\ServiceManager;
use Zend\ServiceManager\Config;
use Zend\I18n\View\HelperConfig as I18nViewHelperConfig;
use Zend\Form\View\HelperConfig as FormViewHelperConfig;
use Zend\View\HelperPluginManager;

$serviceManager = new ServiceManager();
$helperManager  = new HelperPluginManager();
$helperManager->setServiceLocator($serviceManager);

(new I18nViewHelperConfig())->configureServiceManager($helperManager);

$t0 = microtime(true);
(new FormViewHelperConfig())->configureServiceManager($helperManager);
$ms = 1000 * round(microtime(true) - $t0, 5) . ' ms';

echo 'zend-servicemanager-v2 => ' . $ms . PHP_EOL;

$ php70 test.php # < 2ms
$ php56 test.php # ~7-9 ms

All the installed packages have the same version excluding zend-servicemanager

any hint/help?

could this performance degradation be related to ServiceManager 3 configure() method, involving rewriting the alias arrays and performing inner tests on existing keys and called for every registered alias?

or simply is there something wrong in my setup (all this started when overwriting/delegating a new HelperPluginManagerFactory/DelegatorFactory in zend-expressive zendframework/zend-expressive-zendviewrenderer#25
zendframework/zend-form#76 my last comments)

kind regards

PS
forgot to mention that in the zend-expressive test app I obviously use zend opcode cache ext.

[Ocramius]

Could you please convert this into a benchmark PR? We have a dedicated dir
for it...
On May 27, 2016 19:11, "maks feltrin" notifications@github.com wrote:

Working with zend-expressive i found out that migrating to a newer version
that included servicemanage 3 the very same test app was much slower. This
occurred when registering all zend-form helper plugins.

zendframework/zend-expressive-zendviewrenderer#25
zendframework/zend-expressive-zendviewrenderer#25
zendframework/zend-form#76
zendframework/zend-form#76

So i decided to prepare and run 2 simple test scripts whose only purpose
is to register all zend-form view helpers using zend-servicemanager v2 and
v3 and explain the issue here as I believe this repo is more appropriate
for this.
v3 test: zend-form configuration time ~ 22 ms (PHP 7.0), ~52-70 ms (PHP
5.6)

cd /my/test/path/sm3
composer require zend-servicemanager:3.0.*
composer require zend-i18n
composer require zend-form
composer require zend-view

configureServiceManager($helperManager);$t0 = microtime(true);(new FormViewHelperConfig())->configureServiceManager($helperManager);$ms = 1000 \* round(microtime(true) - $t0, 5) . ' ms';echo 'zend-servicemanager-v3 => ' . $ms . PHP_EOL; $ php70 test.php # ~ 22 ms $ php56 test.php # ~52-70 ms v2 test: zend-form configuration time < 2ms (PHP 7.0), ~7-9 ms (PHP 5.6) cd /my/test/path/sm2 composer require zend-servicemanager:2.7.* composer require zend-i18n composer require zend-form composer require zend-view setServiceLocator($serviceManager);(new I18nViewHelperConfig())->configureServiceManager($helperManager);$t0 = microtime(true);(new FormViewHelperConfig())->configureServiceManager($helperManager);$ms = 1000 \* round(microtime(true) - $t0, 5) . ' ms';echo 'zend-servicemanager-v2 => ' . $ms . PHP_EOL; $ php70 test.php # < 2ms $ php56 test.php # ~7-9 ms All the installed packages have the same version excluding zend-servicemanager any hint/help? could this performance degradation be related to ServiceManager 3 configure() method, involving rewriting the alias arrays and performing inner tests on existing keys and called for every registered alias? or simply is there something wrong in my setup (all this started when overwriting/delegating a new HelperPluginManagerFactory/DelegatorFactory in zend-expressive zendframework/zend-expressive-zendviewrenderer#25 https://github.com/zendframework/zend-expressive-zendviewrenderer/issues/25 zendframework/zend-form#76 https://github.com/zendframework/zend-form/issues/76 my last comments) kind regards — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com//issues/122, or mute the thread https://github.com/notifications/unsubscribe/AAJakHgFRQlcGqHxEOA5ffpvddB9f1_Zks5qFyVOgaJpZM4Iosat .

[pine3ree]

@Ocramius @weierophinney

Thank You Marco, writing the benchmark helped me to the right direction for a solution (or at least for the probable cause)

I found out that the performance degradation appears more evidently when aliases of aliases are defined and only when using setAlias(). If using ServiceManager::configure for an array of aliases there is no evident degradation.

Indeed configureServiceManager() method in various HelperConfig classes loop through $config['aliases'] and $config['factories'] calling setAlias and setFactory instead of configure (I haven't checked if this was done to maintain bakckwards compatibility with previous versions)

the bench test i used

<?php

namespace ZendBench\ServiceManager;

use PhpBench\Benchmark\Metadata\Annotations\Iterations;
use PhpBench\Benchmark\Metadata\Annotations\Revs;
use PhpBench\Benchmark\Metadata\Annotations\Warmup;
use Zend\ServiceManager\ServiceManager;

/**
 * @Revs(10)
 * @Iterations(5)
 */
class ManyAliasesBench
{
    /**
     * @var ServiceManager
     */
    private $sm;

    private $aliases_10;
    private $aliases_100;

    public function __construct()
    {
        $this->sm = new ServiceManager([
            'factories' => [
                'fooFactory' => BenchAsset\FactoryFoo::class,
            ],
        ]);

        $this->aliases_10   = $this->createAliases(10);
        $this->aliases_100  = $this->createAliases(100);
    }

    private function createAliases($n)
    {
        $aliases = [];
        for ($i = 1; $i < $n; $i++) {
            $aliases['foo_' . $i] = 'fooFactory';
            $aliases['bar_' . $i] = 'foo_' . $i; // alias of alias
        }

        return $aliases;
    }

    public function benchConfigure10Aliases()
    {
        $sm = clone $this->sm;

        $sm->configure(['aliases' => $this->aliases_10]);
    }

    public function benchSet10Aliases()
    {
        $sm = clone $this->sm;

        foreach ($this->aliases_10 as $alias => $target) {
            $sm->setAlias($alias, $target);
        }
    }

    public function benchConfigure100Aliases()
    {
        $sm = clone $this->sm;

        $sm->configure(['aliases' => $this->aliases_100]);
    }

    public function benchSet100Aliases()
    {
        $sm = clone $this->sm;

        foreach ($this->aliases_100 as $alias => $target) {
            $sm->setAlias($alias, $target);
        }
    }
}

results PHP 5.6

benchConfigure10Aliases ~36μs
benchSet10Aliases ~310μs
benchConfigure100Aliases ~360μs
benchSet100Aliases ~25ms

kind regards

[pine3ree]

@Ocramius @weierophinney

I can confirm that changing Zend\Form\View\HelperConfig method like this:

    public function configureServiceManager(ServiceManager $serviceManager)
    {
        $serviceManager->configure($this->toArray());

        return $serviceManager;
    }

restored my test blog app exec time to 12~15 ms....
ps: sorry for the partial text and later editing , i hit a key by mistake

[Ocramius]

@pine3ree nice findings! Does the removal of the indirection fix the performance issue?

[pine3ree]

@Ocramius
Yes but unfortunately that change breaks compatibility with servicemanager v2 (2.7.x) which does not possess a configure() method. v3 setAlias(), setFactory()..etc etc methods are proxy to the new configure() method. This new method works with array parameters representing a global $config for the manager itself. To maintain compatibility the setters now proxy to configure, sending a partial/single service-class value $config to it. Still configure() deals (has to) with it as a whole service config array.

[weierophinney]

You could add a test for the configure method and, if present, use it, and
if not, call the other methods...
On May 27, 2016 3:10 PM, "maks feltrin" notifications@github.com wrote:

Yes but unfortunately that change breaks compatibility with servicemanager
v2 (2.7.x) which does not possess a configure() method. v3 setALias,
setFactory..etc etc methods are proxy to the new configure() method. This
new method works with array parameters representing a global $config for
the manager itself. To maintain compatibility the setters now proxy to
configure, sending a partial/single service-class value $config to it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#122 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABlVxYQY7qn59vXq1JV-kwTp7LpovToks5qF0-ZgaJpZM4Iosat
.

[pine3ree]

@Ocramius @weierophinney

Maybe zendframework/zend-form#77 (updated wrong repo reference) is not very elegant but it works.
Should I add a similar patch for zend-i18n View\HelperConfig?

Nevertheless I believe that loop calls to set(Alias|Factory|...) should not cause such performance overhead but i see no other solution than going back to single method in body implementation.

kind regards

[pine3ree]

@weierophinney zendframework/zend-form#77 (updated wrong repo reference) :-) already added a PR! kind regards. (oh, messages are not instantly sent in github)

[pine3ree]

...added the same patch for zend-i18n zendframework/zend-i18n#47.

I got back my 12-20 ms execution time: I hope I will not bother you anymore (for the rest of the week).

kind regards and... thank You.

ps
since configure is part of the public interface of sm3 I used method_exists(...) instead of is_callable([$obj, 'method']) ...

[pine3ree]

fixed by :
zendframework/zend-form#77
zendframework/zend-i18n#47