Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Fix incorrect check if $options['input'] was ArrayAccess. #122

Merged

Conversation

TysonAndre
Copy link
Contributor

@TysonAndre TysonAndre commented Sep 17, 2019

Previously, $input was always null, and that should have checked
$options['input'] instead. (for && ! $input instanceof ArrayAccess)
Move the assignment to $input above the conditions.

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior. ArrayAccess was not allowed for SessionArrayStorage and an exception would be thrown
    • Detail the new, expected behavior. ArrayAccess is now allowed for SessionArrayStorage
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?

Previously, $input was always null, and that should have checked
`$options['input']` instead.
Move the assignment to $input above the conditions.
@michalbundyra michalbundyra added this to the 2.8.7 milestone Sep 17, 2019
michalbundyra added a commit that referenced this pull request Sep 19, 2019
Fix incorrect check if $options['input'] was ArrayAccess.
michalbundyra added a commit that referenced this pull request Sep 19, 2019
michalbundyra added a commit that referenced this pull request Sep 19, 2019
@michalbundyra
Copy link
Member

Thanks, @TysonAndre!

@michalbundyra michalbundyra merged commit 9f9ad32 into zendframework:master Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants