Add pod_running_timeout attribute to Kaniko image builder
#2509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add attribute `pod_running_timeout` to `KanikoImageBuilderConfig` with `NonNegativeInt` number type; - Add default value `DEFAULT_KANIKO_POD_RUNNING_TIMEOUT` (defaults to 300) for new attribute `pod_running_timeout` in `KanikoImageBuilderConfig`; - Update method `_run_kaniko_build` in `KanikoImageBuilder` to run `kubectl run` with the argument `--pod-running-timeout`;
- Add description for the `pod_running_timeout` attribute;
- Update styles using `scripts/format.sh`;
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
- Change `NonNegativeInt` to `PositveInt`: `pod_running_timeout` can't be zero, it must be a positive integer to work correctly with `kubectl run` (https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#run);
avishniakov
suggested changes
Mar 14, 2024
docs/book/stacks-and-components/component-guide/image-builders/kaniko.md
Outdated
Show resolved
Hide resolved
safoinme
approved these changes
Mar 14, 2024
…/kaniko.md - Update `pod_running_timeout`; Co-authored-by: Andrei Vishniakov <[email protected]>
avishniakov
approved these changes
Mar 14, 2024
adtygan
pushed a commit
to adtygan/zenml
that referenced
this pull request
Mar 21, 2024
…io#2509) * Add `pod_running_timeout` attribute to `Kaniko` image builder - Add attribute `pod_running_timeout` to `KanikoImageBuilderConfig` with `NonNegativeInt` number type; - Add default value `DEFAULT_KANIKO_POD_RUNNING_TIMEOUT` (defaults to 300) for new attribute `pod_running_timeout` in `KanikoImageBuilderConfig`; - Update method `_run_kaniko_build` in `KanikoImageBuilder` to run `kubectl run` with the argument `--pod-running-timeout`; * Update documention for `KanikoImageBuilder` - Add description for the `pod_running_timeout` attribute; * Update styles for `KanikoImageBuilder` and `KanikoImageBuilderConfig` - Update styles using `scripts/format.sh`; * Fix `pod_running_timeout` attribute type in `KanikoImageBuilderConfig` - Change `NonNegativeInt` to `PositveInt`: `pod_running_timeout` can't be zero, it must be a positive integer to work correctly with `kubectl run` (https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#run); * Update docs/book/stacks-and-components/component-guide/image-builders/kaniko.md - Update `pod_running_timeout`; Co-authored-by: Andrei Vishniakov <[email protected]> --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Andrei Vishniakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I've added the
pod_running_timeoutattribute to theKanikoImageBuilderConfig, so the--pod-running-timeoutflag fromkubectl runcan be specified. By default, a300seconds timeout is set (kubectldefaults to60) with theDEFAULT_KANIKO_POD_RUNNING_TIMEOUT.I've experience some difficulties when using Kaniko on GKE Autopilot, the pod provisioning for the Kaniko executor exceeds the default
60seconds ofkubectl runmost of the time. Thus, it would be a great addition being able to control the timeout for the Pod to be running in the orchestrator.I'm not sure whether such change would require modifications on the dashboard.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes