-
Notifications
You must be signed in to change notification settings - Fork 537
Skypilot: Lambda Edition #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skypilot: Lambda Edition #2526
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quickstart template updates in |
src/zenml/integrations/skypilot_runpod/flavors/skypilot_orchestrator_runpod_vm_flavor.py
Outdated
Show resolved
Hide resolved
src/zenml/integrations/skypilot_runpod/flavors/skypilot_orchestrator_runpod_vm_flavor.py
Outdated
Show resolved
Hide resolved
baf8dd3
to
ef7cadc
Compare
LLM Finetuning template updates in |
…om:zenml-io/zenml into feature/OSSK-470-add-more-skypilot-options
…om:zenml-io/zenml into feature/OSSK-470-add-more-skypilot-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I left some comments, mostly regarding some corrections in the docs page.
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
src/zenml/integrations/skypilot_lambda/orchestrators/skypilot_lambda_vm_orchestrator.py
Outdated
Show resolved
Hide resolved
@@ -50,6 +50,14 @@ Read more about how to configure step-specific resources [here](#configuring-ste | |||
The SkyPilot VM Orchestrator does not currently support the ability to [schedule pipelines runs](/docs/book/user-guide/advanced-guide/pipelining-features/schedule-pipeline-runs.md) | |||
{% endhint %} | |||
|
|||
{% hint style="info" %} | |||
All ZenML pipelines runs are executed using docker containers within the VMs provisioned by the orchestrator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ZenML pipelines runs are executed using docker containers within the VMs provisioned by the orchestrator. | |
All ZenML pipelines runs are executed using Docker containers within the VMs provisioned by the orchestrator. |
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Barış Can Durak <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]>
Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Barış Can Durak <[email protected]>
docs/book/stacks-and-components/component-guide/orchestrators/skypilot-vm.md
Outdated
Show resolved
Hide resolved
…skypilot-vm.md Co-authored-by: Alex Strick van Linschoten <[email protected]>
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes