Upgrading pydantic to 2.11 #3472

bcdurak · 2025-03-28T11:07:54Z

Describe changes

Command	develop Time (s)	feature/upgrading-pydantic-to-2.11 Time (s)	Difference	Status
`zenml --help`	3.007808 ± 0.012083	1.686373 ± 0.013748	-1.321s	✅ Improved
`zenml model list`	4.211289 ± 0.025671	2.718185 ± 0.044351	-1.493s	✅ Improved
`zenml pipeline list`	4.135158 ± 0.027532	2.768479 ± 0.028478	-1.367s	✅ Improved
`zenml stack --help`	3.028235 ± 0.037987	1.722361 ± 0.051498	-1.306s	✅ Improved
`zenml stack list`	5.056318 ± 2.079630	2.759821 ± 0.037323	-2.296s	✅ No longer slow

This PR removes all mlserver related requirements from the MLflow integration because these are dragging in an older version of Pydantic. They are modeled as optional requirements going forward, that the user must install manually if needed.

🎤 💧

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
IMPORTANT: I made sure that my changes are reflected properly in the following resources:
- ZenML Docs
- Dashboard: Needs to be communicated to the frontend team.
- Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
- Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

coderabbitai · 2025-03-28T11:08:01Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-28T11:09:13Z

Documentation Link Check Results

✅ Absolute links check passed
✅ Relative links check passed
_{Last checked: 2025-04-07 16:24:54 UTC}

htahir1

Just some questions otherwise LGTM if ur sure

.github/workflows/performance-profiling.yml

htahir1 · 2025-04-01T15:14:23Z

pyproject.toml

@@ -51,7 +51,7 @@ gitpython = "^3.1.18"
 packaging = ">=24.1"
 passlib = { extras = ["bcrypt"], version = "~1.7.4" }
 psutil = ">=5.0.0"
-pydantic = "~2.8"
+pydantic = "~2.11"


can we do >=2.x, <3? @stefannica @bcdurak

looking at the amount of manual fixes that Baris had to make to allow 2.11 to work, I would say no

Most of the changes are coming from linting, however, if you take a look at models/__init__.py, we had some changes related to the pydantic upgrade as well. I am not sure why this was not failing before, but if we would relax this 2 weeks ago, the release of pydantic 2.11 would make zenml fail completely.

We can alternatively have an upper limit, such as >=2.0, <=2.11, but we would need to be careful how we handle breaking changes.

@bcdurak can you try this out? it would be a big headache solver

But what impact does that have on mlflow examples @stefannica ?

@htahir1 absolutely no impact on any of our examples. This mlserver feature is turned off by default and none of our examples are setting it explicitly. In fact, if you search mlserver in all of the zenml-io GitHub org, you'll not find one mention of it in a demo, example or even notebook.

@stefannica hmm wonder why we even have this then. im just a bit concerned about it , maybe it isn't mentioned explicitly but used in the e2e example?

mlserver is just one flavor of a local mlflow model server. The default one works just as well. I think this feature was never really used, even though it was available.

…pydantic-to-2.11

github-actions · 2025-04-07T16:24:41Z

NLP template updates in examples/e2e_nlp have been pushed.

bcdurak added 2 commits March 28, 2025 12:05

upgrading the dependency

a32dfbb

linting

c77d542

bcdurak requested a review from htahir1 March 28, 2025 11:07

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Mar 28, 2025

bcdurak and others added 4 commits March 28, 2025 12:16

quotation marks

63f37de

paths ignore

a6ee6c9

fixing some of the issues

0af0383

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

5a5918b

htahir1 approved these changes Mar 31, 2025

View reviewed changes

.github/workflows/performance-profiling.yml Outdated Show resolved Hide resolved

bcdurak added 3 commits March 31, 2025 18:14

new model rebuild

6ee7212

new fixes

1d174f3

linting

b50b5ac

bcdurak added the run-slow-ci label Mar 31, 2025

bcdurak and others added 4 commits March 31, 2025 17:37

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

0875f6e

linting

ffb4a04

merged logging

909ae6e

model rebuild

faefc8b

stefannica requested changes Apr 1, 2025

View reviewed changes

.github/workflows/performance-profiling.yml Outdated Show resolved Hide resolved

stefannica approved these changes Apr 1, 2025

View reviewed changes

htahir1 reviewed Apr 1, 2025

View reviewed changes

bcdurak and others added 7 commits April 1, 2025 18:29

correct paths

72f37b4

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

c4f7b2e

Allow a larger version range for Pydantic

4f27360

Merge remote-tracking branch 'origin/develop' into feature/upgrading-…

7a552eb

…pydantic-to-2.11

Remove mlserver requirements

6f543c9

Fix linter errors

30382ea

Fix more linter errors

9a692d0

stefannica and others added 6 commits April 3, 2025 21:40

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

ca7f231

new limit

a568e40

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

e3c567c

new model_rebuild

d41706b

Merge branch 'develop' into feature/upgrading-pydantic-to-2.11

075b680

Auto-update of NLP template

35808a3

bcdurak merged commit 66813b8 into develop Apr 8, 2025
5 checks passed

bcdurak deleted the feature/upgrading-pydantic-to-2.11 branch April 8, 2025 07:15

Upgrading pydantic to 2.11 #3472

Upgrading pydantic to 2.11 #3472

Uh oh!

Conversation

bcdurak commented Mar 28, 2025 • edited by stefannica Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe changes

Pre-requisites

Types of changes

Uh oh!

coderabbitai bot commented Mar 28, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation Link Check Results

Uh oh!

htahir1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Uh oh!

bcdurak commented Mar 28, 2025 •

edited by stefannica

Loading

github-actions bot commented Mar 28, 2025 •

edited

Loading