-
Notifications
You must be signed in to change notification settings - Fork 536
New zenml login and CLI style improvements #3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case not handled is if you do zenml login
once and authenticate through ZenML Pro, then do zenml login again it doesnt show the questionnaire anymore. Is this what we want?
The underlying reason is that zenml login
is also used to switch around between workspaces once authenticated to pro organization
so you can do: zenml login internal
and zenml login demo-tenant
to switch between workspaces.
Right now how it works is that if you do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i agree. left some more comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this looks good. but now we need @bcdurak to take a look too
Closes #3791 |
@bcdurak @htahir1 @schustmi I think I covered all the issues and also passed the scripts for the tests. I hope it is all ok now. Please let me know if there's something else I can fix or do in a better way, as I am more used to work with frontend stuff, and it is my first time working on changes for a CLI interface. Thank you! |
Describe changes
I implemented an interactive login menu for the
zenml login
command to achieve a better user experience by providing clear login options instead of automatically defaulting to ZenML Pro.When users run
zenml login
without arguments, they now see a styled interactive menu with three options:zenml login --local
)This also includes CLI styling improvements across multiple files for better visual consistency and remove unnecessary colors to make it more legible.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes