-
Notifications
You must be signed in to change notification settings - Fork 536
Collect step run exception info #3838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
LLM Finetuning template updates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two general questions as well.
- What do you think about adding this to the metadata of the step run? I am not sure if we should add a DB column just for the exception info.
- Would we need to add something similar for the pipeline runs as well?
@@ -193,6 +200,24 @@ def run( | |||
) | |||
except BaseException as step_exception: # noqa: E722 | |||
step_failed = True | |||
|
|||
exception_info = exception_utils.collect_exception_information( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, this covers the step_instance.call_entrypoint(...)
call. Maybe we can keep parallel to the scope of the logs_context
. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to actually run this right after the user code, as otherwise we might include some stuff from the failure hook etc which is not really the actual cause for the error that caused the step to fail.
Describe changes
This PR implements tracking of exceptions that happen during the step execution. In addition to storing the traceback information, we also try to detect which line in the user step code was the reason that caused this exception, so we can highlight this line (and show the exception inline) in the step code in the dashboard.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes