-
Notifications
You must be signed in to change notification settings - Fork 18
Rearchitecture transfer #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearchitecture transfer #135
Conversation
refactor: dashboard blocs
… can specify the state
…ith dart fix --apply
I found an issue with this build in particulairy. The error |
@maznnwell after some back and forth discussions with the community, we have come to the following changes:
static const Color znnColor = Color(0xFF4FD166);
static const Color qsrColor = Color(0xFF006AFF);
static const Color ztsColor = Color(0xFFFC54AE);
static const Color errorColor = Color(0xFFF40442); |
Done. As well as the UI fixes. I added an icon after the coins, this way the label will be harder to be replicated. |
@maznnwell the receive dropdown list is not populated with a newly created token. Based on the commits, this was fixed, but it doesn’t appear to be working as expected. It’s not a game breaker—let me know if this is easy to fix; otherwise, we can drop it for now. |
While resetting the wallet and creating or importing a new one seems to work now, navigating to the Transfer tab triggers a PendingTransactionBloc exception: "Bad state: Cannot add new events after calling close.". This error causes a red error page in the widget and seems unrecoverable. |
It seems that a newly registered token only appears in the list after 1-2 momentums. I do refresh the list after sending the block for the new token, but it takes time for the network to be updated. The user can manually refresh the list from the refresh icon inside the 'Receive' card. I fixed the other issue as well. |
There is an issue when selecting a token which has the same name as one of the coin symbols. For example: QSR or ZNN. When selecting such a token, the coin is selected in the dropdown list. |
For now, we would like to drop the icons, "coin" suffix, and use parentheses for tokens. This means only tokens have the following suffix: The concept of icons can be revisited and further developed in the future, allowing us to integrate the idea throughout the entire application, rather than limiting it to these two dropdown lists. |
On production, I can't find any token with the symbol QSR or ZNN. Did you create such tokens on testnet? |
Yes, I test on testnet. You can use: Nevermind this issue. I cannot seem to reproduce it anymore. Might be because of some changes I made locally. |
Ok. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. Although it probably took longer than expected, we have achieved a good balance between the existing functionalities and the refactored code. The overall consistency has improved through the use of the token symbol. In the future, we can consider further expansions, such as token names, a token selection dialog, and token icons. However, these require a more extensive approach that falls outside the scope of the current revision.
With this PR I did some changes on how some cards work. The reasoning was: less code and widgets is better for maintaining the code base, I preferred to use Material components as they should be used, making their behavior predictable and consistent.
What was achieved with this PR, besides refactoring the code:
I also upgraded Flutter to 3.27.