Revert "cmake: linker: arm: put RAM sections in RAM region" #59065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
previously approved these changes
Jun 9, 2023
nordicjm
previously approved these changes
Jun 12, 2023
|
Ping here, this resolves an important issue (linker generator unusable) |
carlescufi
dismissed
galak’s stale review
dismissing at this point since this is not fixable in any other way
|
@57300 please rebase |
This reverts commit f5eada5. Fixes zephyrproject-rtos#57590. In order to fix incorrect program headers with CMAKE_LINKER_GENERATOR, issue zephyrproject-rtos#59064 needs to be addressed first. Until then, revert to the status quo from several versions back. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
fix-huge-zephyr-bin
branch
from
f2e3a6f to
b046e33
Compare
nordicjm
approved these changes
Jul 31, 2023
nordicjm
approved these changes
Jul 31, 2023
carlescufi
approved these changes
Jul 31, 2023
tejlmand
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f5eada5.
Fixes #57590.
In order to fix incorrect program headers with CMAKE_LINKER_GENERATOR, issue #59064 needs to be addressed first. Until then, revert to the status quo from several versions back.