Enable the usage of multiple ICE40 in bitbang mode on the same SPI peripheral #87900
Conversation
|
Based upon #87740, hence the DNM. |
benediktibk
force-pushed
the
fix/multiple_ice40_bitbang
branch
2 times, most recently
from
8722dae to
c7202ef
Compare
benediktibk
force-pushed
the
fix/multiple_ice40_bitbang
branch
from
c7202ef to
f876e7e
Compare
github-actions
bot
requested review from
cfriedt,
fkokosinski,
msierszulski and
tgorochowik
|
Looks good. I might take a crack at implementing device deinit for esp32-c3 SPI (if it isn't already done) prior to this being merged, just because this driver was initially added for that platform and it would be good to ensure there are no regressions with it. |
|
The CI error seems to be unrelated to these changes: |
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
@benediktibk - I don't want to block progress here and haven't had the time I would have hoped to keep going with #87995, so preemptive approval. If you rebase and things magically work again, I'll approve as well.
Replace reapplying the original pin configuration via pinctrl in the ICE40 bitbang driver with a device_deinit/device_init. Fixes zephyrproject-rtos#77983. Signed-off-by: Benedikt Schmidt <[email protected]>
benediktibk
force-pushed
the
fix/multiple_ice40_bitbang
branch
from
f876e7e to
c2da7f3
Compare
Thanks, rebase onto main did the trick. |
4 participants
This will fix #77983, but I'm still uncertain if we should actually merge it. Because at least for the hardware which I have available deinit is not yet implemented, so I wasn't even able to test it.
With this PR we will basically change the situation for some devices from the state "you can have only one ICE40" to "the ICE40 is not supported". But, at least in such cases there is now a clear path forward: Implement deinit for the SPI peripheral on this device. Considering this, as well as that this bitbang version of the driver won't be in use for most devices anyway, I think it is better to move along this path.