Skip to content

samples: counter: alarm: fix CI build fail #90709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 6 additions & 26 deletions samples/drivers/counter/alarm/sample.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,12 @@ common:
depends_on: counter
tests:
sample.drivers.counter.alarm:
platform_allow:
- nucleo_f746zg
- nrf51dk/nrf51822
- nrf52dk/nrf52832
- nrf52840dk/nrf52840
- nrf9160dk/nrf9160
- samd20_xpro
- bl5340_dvk/nrf5340/cpuapp
- gd32e103v_eval
- gd32e507z_eval
- gd32f403z_eval
- gd32f450i_eval
- gd32f450z_eval
- gd32e507v_start
- gd32f407v_start
- gd32f450v_start
- gd32f470i_eval
- stm32h735g_disco
- stm32h573i_dk
- rpi_pico
- mr_canhubk3
- s32z2xxdc2/s32z270/rtu0
- s32z2xxdc2/s32z270/rtu1
- s32z2xxdc2@D/s32z270/rtu0
- s32z2xxdc2@D/s32z270/rtu1
- lp_em_cc2340r5
platform_exclude:
- mps2/an385
- mimxrt1060_evk@A/mimxrt1062/qspi
- mimxrt1060_evk@B/mimxrt1062/qspi
- mimxrt1060_evk@C/mimxrt1062/hyperflash
- mimxrt1060_evk@C/mimxrt1062/qspi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess, it's enough to have it without a revision to cover all possible variants:
- mimxrt1060_evk/mimxrt1062/hyperflash
- mimxrt1060_evk/mimxrt1062/qspi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with this. But it seems the twister does not depend on the board.yml, just using the test identifier in mimxrt1060_evk_mimxrt1062_qspi_C.yaml. I applied your suggestion but it does not work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with this. But it seems the twister does not depend on the board.yml, just using the test identifier in mimxrt1060_evk_mimxrt1062_qspi_C.yaml. I applied your suggestion but it does not work.

Hm, strange twister. It means we need to list all combinations for all available revisions.

integration_platforms:
- nucleo_f746zg
sample.drivers.counter.alarm.stm32_rtc:
Expand Down