Skip to content

xtensa: support for more than 32 interrupts #92049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

williamtcdns
Copy link
Collaborator

This change add support for using more than 32 interrupts.

andyross
andyross previously approved these changes Jun 23, 2025
Copy link
Collaborator

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I wasn't aware of this evolution. Seems straightforward; looks like it's just "there are now four register sets to poll at ISR time with the same semantics as the old ones"?

Note that the assumption of 32 hardware interrupts is baked into some of the various SOCs already though, so they won't be able to support this without a little work. But then most of those interrupt controllers tend (sigh) to need new drivers every hardware generation anyway.

Also, and it's not the fault of this PR, but our handler architecture for Xtensa was never great and is really showing its age at this point. The generated C handler thing seemed clever early on but turns out not to generate very good code, and (as you discovered by having to 4x it here) there's a ton of senseless cut/paste going on.

@williamtcdns
Copy link
Collaborator Author

Cool, I wasn't aware of this evolution. Seems straightforward; looks like it's just "there are now four register sets to poll at ISR time with the same semantics as the old ones"?

Correct. Full description can also be found in following section of the Xtensa Instruction Set Architecture (ISA) Reference Manual:
4.4.9 Extended Number of Interrupts Option

@github-actions github-actions bot requested a review from yangbolu1991 June 23, 2025 19:54
@williamtcdns
Copy link
Collaborator Author

Please, how to resolve following twister failure at the Print cloud service information step ? it seems un-related to this PR change:

image

This change add support for using more than 32 interrupts.

Signed-off-by: William Tambe <[email protected]>
@williamtcdns williamtcdns force-pushed the more_than_32_interrupts branch from 6340cd6 to 3324cfc Compare June 24, 2025 14:29
Copy link

@williamtcdns
Copy link
Collaborator Author

I rebased this PR change. Now the twister failures are all about kernel.timer test failing with following error un-related to this PR change: Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/timer/timer_api/src/main.c:763: timer_api_test_timeout_abs: Z_IS_TIMEOUT_RELATIVE(t2) is false.

I will monitor the changes for that test and rebase again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants