-
Notifications
You must be signed in to change notification settings - Fork 7.5k
xtensa: support for more than 32 interrupts #92049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
xtensa: support for more than 32 interrupts #92049
Conversation
5faa426
to
a021e05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I wasn't aware of this evolution. Seems straightforward; looks like it's just "there are now four register sets to poll at ISR time with the same semantics as the old ones"?
Note that the assumption of 32 hardware interrupts is baked into some of the various SOCs already though, so they won't be able to support this without a little work. But then most of those interrupt controllers tend (sigh) to need new drivers every hardware generation anyway.
Also, and it's not the fault of this PR, but our handler architecture for Xtensa was never great and is really showing its age at this point. The generated C handler thing seemed clever early on but turns out not to generate very good code, and (as you discovered by having to 4x it here) there's a ton of senseless cut/paste going on.
Correct. Full description can also be found in following section of the Xtensa Instruction Set Architecture (ISA) Reference Manual: |
a021e05
to
6340cd6
Compare
This change add support for using more than 32 interrupts. Signed-off-by: William Tambe <[email protected]>
6340cd6
to
3324cfc
Compare
|
I rebased this PR change. Now the twister failures are all about I will monitor the changes for that test and rebase again. |
This change add support for using more than 32 interrupts.