fix(qq): respond to WebSocket Ping frames to prevent timeout#4041
Merged
theonlyhennygod merged 1 commit intozeroclaw-labs:masterfrom Mar 20, 2026
Merged
Conversation
The QQ channel WebSocket loop did not handle incoming Ping frames, causing the server to consider the connection dead and drop it. Add a Ping handler that replies with Pong, keeping the connection alive. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
theonlyhennygod
approved these changes
Mar 20, 2026
Collaborator
theonlyhennygod
left a comment
theonlyhennygod
left a comment
There was a problem hiding this comment.
LGTM. Correctly responds to WebSocket Ping frames with a Pong carrying the same payload, breaking on send failure.
theonlyhennygod
requested review from
JordanTheJet and
SimianAstronaut7
as code owners
webhive
pushed a commit
to webhive/zeroclaw
that referenced
this pull request
Mar 24, 2026
…ut (zeroclaw-labs#4041) The QQ channel WebSocket loop did not handle incoming Ping frames, causing the server to consider the connection dead and drop it. Add a Ping handler that replies with Pong, keeping the connection alive. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Message::Pingframes in the QQ channel WebSocket loop by replying withMessage::PongRisk
Medium — behavioral change in
src/channels/qq.rs, no security boundary impact.Test plan
🤖 Generated with Claude Code