Skip to content

fix(approval): auto-approve read-only tools in non-interactive mode#4094

Merged
theonlyhennygod merged 3 commits intomasterfrom
fix/4083-web-search-channel-approval
Mar 21, 2026
Merged

fix(approval): auto-approve read-only tools in non-interactive mode#4094
theonlyhennygod merged 3 commits intomasterfrom
fix/4083-web-search-channel-approval

Conversation

@theonlyhennygod
Copy link
Copy Markdown
Collaborator

Summary

  • Add read-only tools (web_search_tool, web_fetch, calculator, glob_search, content_search, image_info) to the default auto_approve list
  • These tools have no side effects and were being silently denied in channel mode (Telegram, Slack, etc.)
  • Root cause: non-interactive ApprovalManager auto-denies any tool not in auto_approve when autonomy level is not "full"

Test plan

  • Verify web_search_tool works in channel mode without setting autonomy to full
  • Verify existing auto_approve behavior for file_read and memory_recall unchanged
  • Verify tools requiring approval (shell, file_write, etc.) still require it

Closes #4083

Add web_search_tool, web_fetch, calculator, glob_search, content_search,
and image_info to the default auto_approve list. These are read-only tools
with no side effects that were being silently denied in channel mode
(Telegram, Slack, etc.) because the non-interactive ApprovalManager
auto-denies any tool not in auto_approve when autonomy != full.

Closes #4083
@theonlyhennygod theonlyhennygod merged commit c301b1d into master Mar 21, 2026
18 checks passed
@theonlyhennygod theonlyhennygod deleted the fix/4083-web-search-channel-approval branch March 21, 2026 03:57
webhive pushed a commit to webhive/zeroclaw that referenced this pull request Mar 24, 2026
…eroclaw-labs#4094)

* fix(approval): auto-approve read-only tools in non-interactive mode

Add web_search_tool, web_fetch, calculator, glob_search, content_search,
and image_info to the default auto_approve list. These are read-only tools
with no side effects that were being silently denied in channel mode
(Telegram, Slack, etc.) because the non-interactive ApprovalManager
auto-denies any tool not in auto_approve when autonomy != full.

Closes zeroclaw-labs#4083

* fix: remove duplicate default_otp_challenge_max_attempts function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't get web search tool working on channels

1 participant