fix(install): always check Xcode license on macOS#4153
Merged
theonlyhennygod merged 1 commit intomasterfrom Mar 21, 2026
Merged
fix(install): always check Xcode license on macOS#4153theonlyhennygod merged 1 commit intomasterfrom
theonlyhennygod merged 1 commit intomasterfrom
Conversation
…stall-system-deps The Xcode license test-compile was inside install_system_deps(), which only runs when --install-system-deps is passed. On macOS the default path skipped this entirely, so users hit `cc` exit code 69 deep in cargo build. Move the check into the unconditional main flow so it always fires on Darwin.
theonlyhennygod
requested review from
JordanTheJet and
SimianAstronaut7
as code owners
webhive
pushed a commit
to webhive/zeroclaw
that referenced
this pull request
Mar 24, 2026
…stall-system-deps (zeroclaw-labs#4153) The Xcode license test-compile was inside install_system_deps(), which only runs when --install-system-deps is passed. On macOS the default path skipped this entirely, so users hit `cc` exit code 69 deep in cargo build. Move the check into the unconditional main flow so it always fires on Darwin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_system_deps(), which only runs with--install-system-deps. On macOS default installs, this was never calledBefore
After
Test plan
bash -n install.shpasses