fix: route webhook requests through tool loop#5141
Closed
nieta-zjj wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks for the PR. I think this one has been functionally superseded by #6080, which has now merged. The core change here is the one-line switch from the tool-less webhook path to the tool-enabled gateway chat path. #6080 carried that fix forward against the current gateway crate, with the additional session-id validation and security/validation notes needed for the current tree. Because #5141 is now dirty against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing