Skip to content

fix: route webhook requests through tool loop#5141

Closed
nieta-zjj wants to merge 1 commit into
zeroclaw-labs:masterfrom
nieta-zjj:fix/webhook-tool-loop-clean
Closed

fix: route webhook requests through tool loop#5141
nieta-zjj wants to merge 1 commit into
zeroclaw-labs:masterfrom
nieta-zjj:fix/webhook-tool-loop-clean

Conversation

@nieta-zjj
Copy link
Copy Markdown

Summary

  • route webhook requests through the tool-enabled chat path
  • keep webhook behavior aligned with interactive tool execution

Testing

  • cargo test webhook_body_requires_message_field -- --exact

@github-actions github-actions Bot added the gateway Auto scope: src/gateway/** changed. label Mar 29, 2026
@singlerider singlerider requested review from Audacity88 and removed request for SimianAstronaut7 April 29, 2026 08:18
@singlerider singlerider added bug Something isn't working risk: medium Auto risk: src/** or dependency/config changes. size: XS Auto size: <=80 non-doc changed lines. channel Auto scope: src/channels/** changed. needs-author-action Author action required before merge labels Apr 29, 2026
@Audacity88
Copy link
Copy Markdown
Collaborator

Thanks for the PR. I think this one has been functionally superseded by #6080, which has now merged.

The core change here is the one-line switch from the tool-less webhook path to the tool-enabled gateway chat path. #6080 carried that fix forward against the current gateway crate, with the additional session-id validation and security/validation notes needed for the current tree.

Because #5141 is now dirty against master and the webhook tool-loop fix has landed through #6080, I think this PR can be closed as superseded rather than rebased. Thanks for catching the webhook/tool-loop gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working channel Auto scope: src/channels/** changed. gateway Auto scope: src/gateway/** changed. needs-author-action Author action required before merge risk: medium Auto risk: src/** or dependency/config changes. size: XS Auto size: <=80 non-doc changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants