fix(channels): localize runtime command replies#6550
Open
drbparadise wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I do not have label permissions on this repository. Suggested labels from the PR body: bug, risk: medium, size: M, channel, channel:core, runtime. |
95c8320 to
3068af9
Compare
Contributor
Author
|
Follow-up for the locale-dependent test review:
Additional local validation after the amend: HOME=<tmp-with-locale-zh-CN> RUSTUP_HOME=/home/drb/.rustup CARGO_HOME=/home/drb/.cargo \
cargo test -p zeroclaw-channels receipts --lib
# 3 passed; 0 failed
HOME=<tmp-with-locale-zh-CN> RUSTUP_HOME=/home/drb/.rustup CARGO_HOME=/home/drb/.cargo \
cargo test -p zeroclaw-channels process_channel_message_handles_models_command_without_llm_call --lib
# 1 passed; 0 failed
HOME=<tmp-with-locale-zh-CN> RUSTUP_HOME=/home/drb/.rustup CARGO_HOME=/home/drb/.cargo \
cargo test -p zeroclaw-channels process_channel_message_refreshes_available_skills_after_new_session --lib
# 1 passed; 0 failed
cargo fmt --all -- --check
cargo clippy --all-targets -- -D warnings
cargo testThe amend SHA is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master(all contributions)/new,/models,/model,/config,/stop, provider fallback, malformed tool output, context-window overflow, and request timeout onto Fluent-backed CLI strings.zh-CNtranslations so channel users configured for Chinese do not receive these runtime replies in English.enandzh-CNsources.zeroclaw-channelsand CLI Fluent resources inzeroclaw-runtime; behavior should remain the same for English users aside from strings now coming through Fluent.bug,risk: medium,size: M,channel,channel:core,runtime.Validation Evidence (required)
Local validation is the signal CI cannot replace. Run the full battery and paste literal output (tails, failures, warnings — not "all passed").
cargo fmt --all -- --check cargo clippy --all-targets -- -D warnings cargo test$ cargo fmt --all -- --check # exit 0; no output$ cargo clippy --all-targets -- -D warnings Checking zeroclaw-runtime v0.7.5 (/tmp/zeroclaw-channel-runtime-i18n/crates/zeroclaw-runtime) Checking zeroclaw-hardware v0.7.5 (/tmp/zeroclaw-channel-runtime-i18n/crates/zeroclaw-hardware) Checking zeroclaw-channels v0.7.5 (/tmp/zeroclaw-channel-runtime-i18n/crates/zeroclaw-channels) Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.47sSecurity & Privacy Impact (required)
Yes/No for each. Answer any
Yeswith a 1–2 sentence explanation.No)No)No)No)Yes, describe the risk and mitigation: N/ACompatibility (required)
Yes)No)NoorYesto either: Existing users do not need upgrade steps. The same runtime commands and routing behavior remain; only user-visible text now resolves through existing Fluent locale loading.Rollback (required for
risk: mediumandrisk: high)git revert 3068af9d{channel-runtime-...}placeholders, or affected channel command replies fail to render expected text.Supersede Attribution (required only when
Supersedes #is used)#<pr> by @<author>, one per line): N/ACo-authored-bytrailers added in commit messages for incorporated contributors? (No)No, why (inspiration-only, no direct code/design carry-over): No superseded PR or human co-author work was incorporated.