feat(cli): add shell tab completion with install/uninstall#725
Closed
reidliu41 wants to merge 1 commit intozeroclaw-labs:mainfrom
Closed
feat(cli): add shell tab completion with install/uninstall#725reidliu41 wants to merge 1 commit intozeroclaw-labs:mainfrom
reidliu41 wants to merge 1 commit intozeroclaw-labs:mainfrom
Conversation
PR intake checks found warnings (non-blocking)Fast safe checks found advisory issues. CI lint/test/build gates still enforce merge quality.
Action items:
Run logs: https://github.com/zeroclaw-labs/zeroclaw/actions/runs/22188837783 Detected blocking line issues (sample):
Detected advisory line issues (sample):
|
|
Hi @reidliu41, friendly automation nudge from PR hygiene. This PR has had no new commits for 36h and still needs an update before merge:
Recommended next steps
Maintainers: apply |
9c0f9a6 to
503fd86
Compare
Contributor
Author
|
@chumyin can you help to take a look this? thanks |
Contributor
Author
|
since #1082 updated, may close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
significant friction for a CLI with 15+ top-level commands, nested subcommands, and typed flags.
friction, reduces typos, and makes the full command surface discoverable without reaching for
--help.zeroclaw completion install [--shell bash|zsh|fish]andzeroclaw completion uninstall.Install auto-detects the shell via
$SHELL, writes a static completion script to~/.local/share/zeroclaw/completions/, and appends a guarded source line to the rc file. Fish uses its nativecompletions directory with no rc modification. Uninstall cleanly removes the script and rc line via a stable marker (
# zeroclaw completion).additive UX layer. New module
src/completion.rsis fully self-contained with no cross-module coupling.Dependency Impact
Net new transitive dependencies: zero.
clap_completeis the official completion companion maintained by the clap team. Its entire dependency tree(
clap_builder,clap_lex,anstream, etc.) is already present in the project via the existingclapdependency.cargo tree -p clap_completeconfirms no new crates are introduced.Label Snapshot (required)
risk: low|medium|high):size: XS|S|M|L|XL, auto-managed/read-only):core|agent|channel|config|cron|daemon|doctor|gateway|health|heartbeat|integration|memory|observability|onboard|provider|runtime|security|service|skillforge|skills|tool|tunnel|docs|dependencies|ci|tests|scripts|dev, comma-separated):<<<<<<< chore/labeler-spacing-trusted-tier
<module>: <component>, for examplechannel: telegram,provider: kimi,tool: shell):=======
<module>:<component>, for examplechannel:telegram,provider:kimi,tool:shell):trusted contributor|experienced contributor|principal contributor|distinguished contributor, auto-managed/read-only; author merged PRs >=5/10/20/50):Change Metadata
bug|feature|refactor|docs|security|chore):runtime|provider|channel|memory|security|ci|docs|multi):Linked Issue
Supersede Attribution (required when
Supersedes #is used)#<pr> by @<author>, one per line):Co-authored-bytrailers added for materially incorporated contributors? (Yes/No)No, explain why (for example: inspiration-only, no direct code/design carry-over):\n): (Pass/Fail)Validation Evidence (required)
Commands and result summary:
cargo fmt --all -- --check cargo clippy --all-targets -- -D warnings cargo testSecurity Impact (required)
Yes/No)Yes/No)Yes/No)Yes/No)Yes, describe risk and mitigation:Privacy and Data Hygiene (required)
pass|needs-follow-up):Compatibility / Migration
Yes/No)Yes/No)Yes/No)Human Verification (required)
What was personally validated beyond CI:
Side Effects / Blast Radius (required)
Agent Collaboration Notes (recommended)
AGENTS.md+CONTRIBUTING.md):Rollback Plan (required)
Risks and Mitigations
List real risks in this PR (or write
None).