ENV['RACK_ENV'] == 'test' silently disables retry backoff in BazaRb#attempt

[VasilevNStas]

ENV["RACK_ENV"] == "test" silently disables retry backoff in BazaRb#attempt

Severity: MEDIUM

Location

lib/baza-rb.rb:629,654:

sleep(seconds) unless ENV["RACK_ENV"] == "test"

Problem

Retry backoff is globally controlled by an environment variable. Three issues:

1. Hidden behavior: Any code setting RACK_ENV=test (or RAILS_ENV=test, or APP_ENV=test) disables backoff
2. Inconsistency: Production behavior is controlled by an undocumented env var
3. Untestable: Backoff logic cannot be tested (it is disabled in tests)

Recommended fix

Parameterize via constructor:

def initialize(..., backoff: true)
  @backoff = backoff
end

Then in tests: BazaRb.new(..., backoff: false). This makes the behavior explicit and testable.

[0crat]

@VasilevNStas Thanks for reporting a new bug! You've earned +18 points. By reporting bugs, you help our project improve its quality. If you find anything else in the repository that doesn't look as good as you might expect, do not hesitate to report it. Your running score is +2044; don't forget to check your Zerocracy account too).