Skip to content

docs: fix retries YARD default from 3 to 5 in BazaRb#initialize#284

Open
SAY-5 wants to merge 1 commit into
zerocracy:masterfrom
SAY-5:278
Open

docs: fix retries YARD default from 3 to 5 in BazaRb#initialize#284
SAY-5 wants to merge 1 commit into
zerocracy:masterfrom
SAY-5:278

Conversation

@SAY-5

@SAY-5 SAY-5 commented May 21, 2026

Copy link
Copy Markdown

The YARD comment on lib/baza-rb.rb:65 documented retries: as (default: 3), but the keyword default on line 69 is 5. This aligns the doc with the code. Closes #276.

@kreinba kreinba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YARD comment on line 65 now matches the keyword default on line 69, which is the exact change issue #276 asked for. No code paths shift, CI is green on the rake matrix, and the only red signal is the pre-existing FOSSA license check on master. Ready to merge.

@0crat

0crat commented May 22, 2026

Copy link
Copy Markdown

@kreinba Thanks for the review! 🎉 You've earned +6 points for this code review. Here's the breakdown according to our work policy: +18 points as the base reward, -8 points deducted for absolutely no comments posted during review, and -4 points deducted for having only 2 hits-of-code (less than the required 24). Your running score is +471 - keep up the great work and don't forget to check your Zerocracy account too!

@edmoffo edmoffo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc default now matches the keyword default on line 69. Diff is minimal and scope-bound to the YARD line on lib/baza-rb.rb:65.

@bibonix bibonix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring now matches the actual default of 5 for the retries keyword argument on BazaRb#initialize at lib/baza-rb.rb:62. One-line scope, no behavior change, CI green across the matrix. No inline comments.

@0crat

0crat commented Jun 23, 2026

Copy link
Copy Markdown

@bibonix Thanks for the review! You've earned +6 points for this: +18 as a basis; -8 for absolutely no comments posted; -4 for too few (2) hits-of-code. Your running score is +696; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YARD default for retries: in BazaRb#initialize says 3 but code uses 5

5 participants