#354: fix live test CI — increase timeout, fix elapsed time bug, improve name uniqueness#393
#354: fix live test CI — increase timeout, fix elapsed time bug, improve name uniqueness#393VasilevNStas wants to merge 0 commit into
Conversation
|
@yegor256 could you please review this PR when you have a moment? This is a CI fix for issue #354 —
The fix increases the timeout to 5 minutes, corrects the elapsed-time display, and adds a timestamp to All other open PRs (#392, #390, #389, #388, #387, #386, #384, #382, #381, #380, #379, #378, #377, #376, #375, #374, #373) currently show red CI for the same reason — once this is merged, their CI will turn green and they can be reviewed normally. As per your article "Don't merge into a broken master" (https://www.yegor256.com/2025/04/19/dont-merge-into-broken-master.html), I understand that we should not submit PRs while master is broken. This PR is an attempt to fix master first, before proceeding with feature changes. |
|
@VasilevNStas the build is still broken. Let me fix the platform first, then we get back to this problem here. |
b43f94a to
d027976
Compare
bcf0dd5 to
ec5be64
Compare
|
Hi @yegor256! Just a gentle reminder about #393 (comment) — we've got 18 other PRs (#352, #392, #390, etc.) that are blocked by the same This PR (#393) is now fully green and fixes three issues:
The other 18 PRs have been rebased on this fix, so once the platform is stable and this PR is merged, they should turn green too. All of them fail only on Whenever you have time to look at the platform side, we're ready to go 👍 |
Problem
test_live_full_cyclefails in CI with:Two bugs identified:
0sdue toTime.now - Time.now(always zero)fake_nameusesSecureRandom.hex(8)without timestamp, risking collisions with parallel CI runsSolution
t0 = Time.nowbefore the wait and use(Time.now - t0).roundin the error message (fixes the always-zero bug)wait_fortimeout from 2 to 5 minutesfake_name:"fake#{Time.now.to_i}-#{SecureRandom.hex(4)}"— eliminates collision risk between parallel CI runsVerification
Closes #354.