ci: run latexmk on pull requests to master, closes #16#19
Conversation
Pair the existing push trigger with a pull_request: branches: [master] trigger so the latexmk build runs on every pull request that targets master, matching the trigger surface of every other workflow in .github/workflows. The deploy step keeps its `if: github.ref == 'refs/heads/master'` guard, so gh-pages is still updated only from master pushes. Closes zerocracy#16
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Approved current head 750e686640c36c1a894da533bc03f438cd22025c.
The diff is limited to .github/workflows/latexmk.yml and adds the missing pull_request trigger for master while preserving the existing push trigger and the deploy step guard if: github.ref == 'refs/heads/master', so the PDF build now runs on PRs without deploying from PR events.
Validation/readback:
- GitHub
actionlint,bibcop,copyrights,markdown-lint,pdd,reuse,typos,xcop, andyamllintchecks are successful on this head. - The PR latexmk run
26390650683fails inyegor256/latexmk-action@0.19.0becausefontspeccannot findmolot-regular. - The latest
masterlatexmk run26386955857fails with the samemolot-regularfont error, so this is an existing baseline/toolchain failure exposed by the new PR trigger, not caused by the trigger-only patch. - Local YAML parse with Ruby
YAML.load_file-> OK. git diff --check origin/master...HEAD-> clean.- Diff Gitleaks -> no leaks.
Local actionlint and yamllint binaries are not installed here, so I relied on the successful GitHub checks for those two validators.
|
@GHX5T-SOL Great work on the review! 🎯 You've earned +6 points (base +18, with deductions for missing comments and limited code coverage of 3 hits). Your total score is now +206 - keep up the momentum and check your Zerocracy account for updates! |
|
@bibonix the Fix: rebase this branch on the latest Then CI should pass. |
Closes #16. The
latexmkworkflow was the only check in.github/workflows/that did not run onpull_requestevents, so pull requests againstmastercould pass every other check and still break thelatexmk -pdfbuild that producesbrand-book.pdf.The change adds
pull_request: branches: [master]next to the existingpush: branches: [master]trigger in.github/workflows/latexmk.yml. TheJamesIves/github-pages-deploy-actionstep keeps itsif: github.ref == 'refs/heads/master'guard, so thegh-pagesdeploy is still gated to master pushes; pull requests now exercise the build path through thecp brand-book.pdf gh-pagesstep but do not publish.Validated locally by running
yamllint .github/workflows/latexmk.ymlagainst the modified file (no output) and by re-reading the diff to confirm the deploy guard is unchanged. CI on the pull request itself will exercise the full workflow set, including the now-triggered latexmk job.