#458: render both between bounds

[akmhatey-ai]

Fixes #458.

The bylaw printer for between treated the clamped value as the lower bound and omitted the upper bound. This changes the rendering to describe the value and both bounds: _b_ clamped between **3** and **120**.

Currentness and duplicate checks:

• Issue Fbe::Award::PTerm#to_s for :between drops the upper bound and mislabels the value as a bound #458 is open, labeled bug and help wanted, and unassigned.
• gh pr list --repo zerocracy/fbe --state all --search "458 OR between upper bound PTerm Award" returned no PRs.
• Broader PR searches for PTerm between and clamped between returned no PRs.
• The same-scope issue search returned only Fbe::Award::PTerm#to_s for :between drops the upper bound and mislabels the value as a bound #458.

Validation:

• New regression failed before the patch with markdown saying set _b_ to at least _b_ and at most **3**.
• ruby -e "gem 'minitest', '6.0.6'; gem 'minitest-mock', '5.27.0'; load 'test/fbe/test_award.rb'" passed: 8 tests, 43 assertions.
• rubocop lib/fbe/award.rb test/fbe/test_award.rb passed with no offenses.
• ruby -c lib/fbe/award.rb; ruby -c test/fbe/test_award.rb passed.
• git diff --check and git diff --cached --check passed.
• git diff --cached | gitleaks stdin --no-banner --redact reported no leaks.

Limitations:

• bundle exec rake test TEST=test/fbe/test_award.rb is locally blocked on this Windows checkout because Bundler cannot find locked gems rdoc-7.2.0, psych-5.3.1, and parallel-2.0.1, and the environment also lacks grep on PATH. The focused direct Ruby test above was run instead.

[GHX5T-SOL]

Reviewed the two-file diff against #458. The between bylaw text now names the value and both bounds, matching the operand order used by BTerm#calc, and the regression covers the rendered bylaw string.

Validation I ran on bbfd7aaf3b525167f9853fa42ee104863954509b:

• env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec ruby -Itest test/fbe/test_award.rb -- --no-cov -> 8 tests, 43 assertions, 0 failures, 0 errors.
• env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rake test -> 284 tests, 804 assertions, 0 failures, 0 errors, 9 skips.
• env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- bundle exec rubocop lib/fbe/award.rb test/fbe/test_award.rb --format simple -> 2 files inspected, no offenses detected.
• env BUNDLE_PATH=/private/tmp/bundle-fbe-488 mise x ruby@3.3.11 -- ruby -c lib/fbe/award.rb and ... -- ruby -c test/fbe/test_award.rb -> Syntax OK.
• git diff --check origin/master...HEAD -> passed.
• git diff origin/master...HEAD | gitleaks stdin --no-banner --redact --exit-code 1 -> no leaks found.

No changes requested.

[0crat]

@GHX5T-SOL Thanks for the review! You've earned +6 points for this contribution: +18 as a basis, -8 for absolutely no comments posted, and -4 for fewer than 24 hits-of-code (7 total). Your running score is +134; don't forget to check your Zerocracy account too.

[yegor256]

@akmhatey-ai merge conflicts here

[yegor256]

Please fix the merge conflicts so this pull request can be merged.

[morphqdd]

Correct fix for #458 — between has three operands (value, min, max), but the old text rendered at least operands[0] and at most operands[1], dropping operands[2] and mislabeling the value as a bound. The new X clamped between MIN and MAX renders all three correctly, and the test pins the markdown. LGTM.

[morphqdd]

Reads correctly now: for (between b 3 120) it renders b clamped between 3 and 120 instead of the previous nonsensical at least b and at most 3. Good catch on the dropped third operand.

[0crat]

@morphqdd Thanks for the review! You've earned +9 points for this: +18 as a basis; -5 for very few (1) comments; -4 for too few (7) hits-of-code. Your running score is +756; don't forget to check your Zerocracy account too).

[yegor256]

@akmhatey-ai merge conflict here