#583 Make Trace array thread-safe with Mutex#605
Merged
Conversation
Contributor
Author
|
@yegor256 please review |
yegor256
reviewed
Jul 17, 2026
| - workflow_run_usage | ||
| Elegant/GoodVariableName: | ||
| AllowedNames: | ||
| - trace_mutex |
Member
There was a problem hiding this comment.
@VasilevNStas can't you call it just mutex? read: https://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html
VasilevNStas
commented
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@tracearray inFbe::Middleware::Traceis accessed from multiple threads without synchronization. When Octokit fires concurrent requests, a race condition occurs: simultaneous read/write on@tracecan corrupt the data.Solution
Trace middleware (
lib/fbe/middleware/trace.rb):@mutex = Mutex.newin constructor@tracereads/writes wrapped with@mutex.synchronizeDecoor (
lib/fbe/middleware/trace.rb):trace_mutexparameter toprint_trace!@trace.clearwrapped with@mutex.synchronizeOcto (
lib/fbe/octo.rb):trace_mutex = Mutex.newprint_trace!callRubocop (
.rubocop.yml):trace_mutextoElegant/GoodVariableName AllowedNamesTests
90 tests, 0 failures, 0 errors, 2 skips
Closes #583