#577 Rescue PMP type conversion errors with Fbe::Error#614
Open
VasilevNStas wants to merge 4 commits into
Open
#577 Rescue PMP type conversion errors with Fbe::Error#614VasilevNStas wants to merge 4 commits into
VasilevNStas wants to merge 4 commits into
Conversation
Contributor
Author
|
@yegor256 please review this |
yegor256
reviewed
Jul 17, 2026
| else default | ||
| end | ||
| rescue ArgumentError, TypeError => e | ||
| msg = "Invalid default value '#{default}' for PMP property '#{param}' in area '#{area}': #{e.message}" |
VasilevNStas
commented
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a PMP property value or default is non-numeric (e.g.,
"abc") but the schema declarestype: intortype: float,Integer()/Float()raisesArgumentErrorwhich propagates as an unhelpful crash.Solution
Wrapped both the default value conversion (XML defaults) and the result value conversion (factbase query) in
begin/rescueblocks. IfArgumentErrororTypeErroroccurs, a descriptiveFbe::Erroris raised with details about the property, area, and offending value.Closes #577