Skip to content

lib/qos_search.rb fragile e.name == :get heuristic #1671

Description

@sdghsdkjlas27-dotcom

DESCRIPTION:
lib/qos_search.rb lines 35-37 rescue NoMethodError and re-raise unless e.name == :get. This introspection is brittle - if the octokit gem changes the method name (e.g. wraps with method_missing delegate), e.name will differ and the original NoMethodError propagates as if it were uncaught. Also, the fallback octo.rate_limit.remaining may itself fail in newer Octokit versions.

REPRODUCTION:

  1. Upgrade octokit/fbe to a version that changes the API surface.
  2. The fallback path silently fails.

IMPACT:
Runtime fragility on dependency upgrade.

RELATED FILES:
lib/qos_search.rb
lib/pull_request.rb (same pattern at lines 32-37)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions