#1703: prevent replacement string injection in update-version action#1754
Open
VasilevNStas wants to merge 1 commit into
Open
#1703: prevent replacement string injection in update-version action#1754VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
Use function callback for String.prototype.replace() to avoid processing of $ backreference patterns in the replacement value.
Contributor
Author
|
@yegor256 plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
String.prototype.replace()interprets$patterns ($&, ``,$', etc.) in string replacement values. If a tag name ever contained these characters, the README content would be silently corrupted.Fix
Use a function callback instead of a string for
replace()— function return values are used literally without any$processing.Closes #1703