#1661: prevent infinite loop in earliest() commit pagination#1757
Open
VasilevNStas wants to merge 2 commits into
Open
#1661: prevent infinite loop in earliest() commit pagination#1757VasilevNStas wants to merge 2 commits into
VasilevNStas wants to merge 2 commits into
Conversation
Replace while loop with proper page-based pagination and a max-iteration guard (100 pages) to prevent infinite loops on repos with long commit history.
Contributor
Author
|
@yegor256 please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
earliest()method ingithub-events.rbfrom sha-based pagination to page-based pagination with a safety limit of 100 pages, preventing infinite loops when commit history is very large or GitHub returns unexpected results.Also updates test stubs to match the new
page=Nparameter in commit requests.Closes #1661