#1678: advance cursor when search returns empty results#1758
Open
VasilevNStas wants to merge 1 commit into
Open
#1678: advance cursor when search returns empty results#1758VasilevNStas wants to merge 1 commit into
VasilevNStas wants to merge 1 commit into
Conversation
When the search query (QoS or GitHub API) returns no items for the current cursor position, increment the cursor by 1 to avoid getting stuck on the same value and entering an infinite loop.
Contributor
Author
|
@yegor256 please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GitHub Search API returns an empty page of results, the cursor (
issue) doesn't advance and the loop spins forever on the same empty page.Added
issue += 1 if seen.empty? && issue <= firstto increment the cursor when no results are returned, ensuring forward progress.Closes #1678