#1664: add reactions cache to reduce N+1 API calls#1771
Open
VasilevNStas wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@yegor256 plz review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an instance variable cache (
@reactions) inJp.count_appreciated_commentsto avoid N+1 API calls when the same comment reactions are looked up multiple times for the same pull request.The cache is keyed by comment ID and memoizes the result of
issue_comment_reactionsandpull_request_review_comment_reactions.Closes #1664