Skip to content

#1651: fix memory exhaustion in find-missing-issues #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#1651: fix memory exhaustion in find-missing-issues #1776

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1a0ed9
#1721: add per_page: 100 to pull_request_reviews to reduce pagination…
VasilevNStas Jul 3, 2026
0e25c45
#1651: replace array-based missing issue detection with streaming ite…
VasilevNStas Jul 3, 2026
0bac765
#1651 fix variable names for Elegant/GoodVariableName, revert unrelat…
VasilevNStas Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions judges/find-missing-issues/find-missing-issues.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
issues.uniq!
issues.sort!
next if issues.empty?
must = (issues.min..issues.max).to_a
missing = must - issues
existing = issues.to_set
added = []
checked = []
missing.each do |i|
(issues.min..issues.max).each do |i|
next if existing.include?(i)
next if ts.has?('github', r.repository, i)
json =
begin
Expand Down Expand Up @@ -91,12 +91,13 @@
added << i
break if added.size > 16
end
if missing.empty?
if (issues.max - issues.min + 1) == issues.size
$loog.info("No missing issues in #{repo}")
else
missed = (issues.max - issues.min + 1) - issues.size
$loog.info(
[
"Checked #{checked.size} out of #{missing.count} missing issues",
"Checked #{checked.size} out of #{missed} missing issues",
"in #{repo}, #{added.count} facts added:",
added.joined(max: 8)
].join(' ')
Expand Down
Loading