Skip to content

#1689: fix set -e masking test failures in Makefile #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VasilevNStas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#1689: fix set -e masking test failures in Makefile #1785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df06a9
#1689: fix set -e masking test/entry exit codes in Makefile
VasilevNStas Jul 4, 2026
f4442fa
#1689: remove unnecessary ; \; with ONESHELL
VasilevNStas Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ rubocop:

test: target/docker-image.txt
img=$$(cat target/docker-image.txt)
docker run --rm --entrypoint '/bin/bash' "$${img}" -c 'bundle exec judges test --disable live --lib /action/lib /action/judges'
echo "$$?" > target/test.exit
docker run --rm --entrypoint '/bin/bash' "$${img}" -c 'bundle exec judges test --disable live --lib /action/lib /action/judges' || rc=$$?
echo "$${rc:-0}" > target/test.exit

entry: target/docker-image.txt
./test-action.sh "$$(cat $<)"
echo "$$?" > target/entry.exit
./test-action.sh "$$(cat $<)" || rc=$$?
echo "$${rc:-0}" > target/entry.exit

rmi: target/docker-image.txt
img=$$(cat $<)
Expand Down
Loading