#1708: fix die() exit code guarantee under set -e#1787
Open
VasilevNStas wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@yegor256 plz review |
Member
|
@VasilevNStas looks like a mix of two changes in one PR |
0c7af37 to
5a8f5a2
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1708
Fix
die()exit code guarantee underset -e. Whenset -eis active and theechoto stderr fails, the shell exits immediately before reachingexit 1. Adding|| trueensures the function always reachesexit 1.