Skip to content

#1708: fix die() exit code guarantee under set -e#1787

Open
VasilevNStas wants to merge 1 commit into
zerocracy:masterfrom
VasilevNStas:1708-die-set-e
Open

#1708: fix die() exit code guarantee under set -e#1787
VasilevNStas wants to merge 1 commit into
zerocracy:masterfrom
VasilevNStas:1708-die-set-e

Conversation

@VasilevNStas

@VasilevNStas VasilevNStas commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Closes #1708

Fix die() exit code guarantee under set -e. When set -e is active and the echo to stderr fails, the shell exits immediately before reaching exit 1. Adding || true ensures the function always reaches exit 1.

@VasilevNStas

Copy link
Copy Markdown
Contributor Author

@yegor256 plz review

@yegor256

yegor256 commented Jul 8, 2026

Copy link
Copy Markdown
Member

@VasilevNStas looks like a mix of two changes in one PR

@VasilevNStas

VasilevNStas commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@yegor256

Fixed — separated the FakeOctokit patch into its own PR (included in #1786). This PR now only has the die() fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

makes/test-common.sh die() doesn't restore set -e

2 participants