#228 Replace ARGV with ENV for --live/--verbose flags in Rakefile#268
Open
VasilevNStas wants to merge 2 commits into
Open
#228 Replace ARGV with ENV for --live/--verbose flags in Rakefile#268VasilevNStas wants to merge 2 commits into
VasilevNStas wants to merge 2 commits into
Conversation
Rake consumes ARGV flags before the task body runs, making
ARGV.include?('--live') and ARGV.include?('--verbose') dead code.
Switch to ENV['LIVE'] and ENV['VERBOSE'], invoked as:
LIVE=true bundle exec rake judges
VERBOSE=true bundle exec rake judges
- Add language specifier to fenced code block (MD040) - Use 1-prefix for all ordered list items (MD029) - Fix table pipe spacing (MD060) - Break long table line under 80 chars (MD013)
Contributor
Author
|
@yegor256 plz review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rake consumes CLI flags before the task body runs, so
ARGV.include?('--live')andARGV.include?('--verbose')inRakefile:26-27never see those flags — Rake aborts withinvalid option: --live.Switch to environment variables:
LIVE=true bundle exec rake judges— enables live APIVERBOSE=true bundle exec rake judges— enables verbose outputFixes #228