#234 Remove redundant bundler-cache: true from rake.yml#271
Open
VasilevNStas wants to merge 2 commits into
Open
#234 Remove redundant bundler-cache: true from rake.yml#271VasilevNStas wants to merge 2 commits into
VasilevNStas wants to merge 2 commits into
Conversation
setup-ruby with bundler-cache runs bundle install into a default path, then the next steps override the path to vendor/bundle and run bundle install again — making the cache useless and the install run twice.
- Add language specifier to fenced code block (MD040) - Use 1-prefix for all ordered list items (MD029) - Fix table pipe spacing (MD060) - Break long table line under 80 chars (MD013)
Contributor
Author
|
@yegor256 please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflow called
ruby/setup-rubywithbundler-cache: true, which installs gems into the default path and saves a cache — then immediately overrode the Bundler path tovendor/bundleand ran a secondbundle installfrom scratch, making the first install and its cache entirely wasted.Fixed by removing
bundler-cache: true.setup-rubynow just installs Ruby, and the explicitbundle installhandles gem installation intovendor/bundle.Fixes #234