Add "xing" social icon #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added two new icons to the adritian-icons font set: - "table-list" icon - "square-xing" icon - Updated font files and CSS to include the new icons - Updated homepage data to include Xing social icon - Updated .gitignore to exclude local Hugo build files
zetxek
deleted the
168-add-xing-social-media-icon-support-to-adritian-hugo-theme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #168 requested by @klangborste
As mentioned in #168, some steps to modify the font:
As mentioned in #84, the font is created with https://fontello.bableck.dev/
You need to upload the latest
config.jsonfile from the theme, that you can find instatic/fonts/config.json, and import it in fontello:In fontello, the icons selection as well as their codes is configured:
Once that's ready, fontello allows you to generate the zip containing the assets:
fontello-bba22101.zip
A minimum change is required in the code that fontello generates: replacing
/fontby/fonts, as that's the path used at the theme:Aside of that - they can be edited directly, as shown here by adding a "xing" icon to the top section:
I hope that's useful for other times! :)