aarch64: avoid -Wunused_parameter in older CPUs #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In systems with no LSE support, the parameter goes unused. Add the missing marker and while at it, make sure that the difference of behaviour is externally visible by updating the platform identifier.
zherczeg
reviewed
Aug 11, 2025
| @@ -24,9 +24,15 @@ | |||
| * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| */ | |||
|
|
|||
| #ifdef __ARM_FEATURE_ATOMICS | |||
| #define ARM_ATOMIC_INFO " (LSE)" | |||
There was a problem hiding this comment.
Is LSE the official name? Not CAS (compare and swap)?
There was a problem hiding this comment.
LSE (for Large Systems Extension) is the name of the extension (AKA feature), which was include in Armv8.1-A.
CAS is the name of the implementation, and while I have no preference either way, but this was less generic and therefore less likely to cause confusion IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while building recent PCRE2 in a 64-bit arm Linux, but likely to also affect others